-
Notifications
You must be signed in to change notification settings - Fork 319
Add springboot smoke tests for the open feature SDK #9961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fdda03b to
d926f7a
Compare
6fcda55 to
188fdc6
Compare
188fdc6 to
de1816f
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~c48da34534, baseline=1.57.0-SNAPSHOT~c79dfc656d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.102 s) : 0, 1102424
Total [baseline] (8.869 s) : 0, 8869248
Agent [candidate] (1.108 s) : 0, 1108210
Total [candidate] (8.828 s) : 0, 8828458
section iast
Agent [baseline] (1.24 s) : 0, 1239510
Total [baseline] (9.539 s) : 0, 9539314
Agent [candidate] (1.24 s) : 0, 1239748
Total [candidate] (9.529 s) : 0, 9529414
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~c48da34534, baseline=1.57.0-SNAPSHOT~c79dfc656d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.502 ms) : 0, 1502
crashtracking [candidate] (1.488 ms) : 0, 1488
BytebuddyAgent [baseline] (709.081 ms) : 0, 709081
BytebuddyAgent [candidate] (713.104 ms) : 0, 713104
GlobalTracer [baseline] (248.953 ms) : 0, 248953
GlobalTracer [candidate] (250.082 ms) : 0, 250082
AppSec [baseline] (32.025 ms) : 0, 32025
AppSec [candidate] (32.299 ms) : 0, 32299
Debugger [baseline] (63.464 ms) : 0, 63464
Debugger [candidate] (63.698 ms) : 0, 63698
Remote Config [baseline] (642.281 µs) : 0, 642
Remote Config [candidate] (621.567 µs) : 0, 622
Telemetry [baseline] (8.258 ms) : 0, 8258
Telemetry [candidate] (8.262 ms) : 0, 8262
Flare Poller [baseline] (3.696 ms) : 0, 3696
Flare Poller [candidate] (3.73 ms) : 0, 3730
section iast
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (832.065 ms) : 0, 832065
BytebuddyAgent [candidate] (833.421 ms) : 0, 833421
GlobalTracer [baseline] (237.705 ms) : 0, 237705
GlobalTracer [candidate] (237.586 ms) : 0, 237586
AppSec [baseline] (33.982 ms) : 0, 33982
AppSec [candidate] (32.781 ms) : 0, 32781
Debugger [baseline] (60.144 ms) : 0, 60144
Debugger [candidate] (59.75 ms) : 0, 59750
Remote Config [baseline] (543.85 µs) : 0, 544
Remote Config [candidate] (552.002 µs) : 0, 552
Telemetry [baseline] (7.638 ms) : 0, 7638
Telemetry [candidate] (7.58 ms) : 0, 7580
Flare Poller [baseline] (3.484 ms) : 0, 3484
Flare Poller [candidate] (3.465 ms) : 0, 3465
IAST [baseline] (27.596 ms) : 0, 27596
IAST [candidate] (28.331 ms) : 0, 28331
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~c48da34534, baseline=1.57.0-SNAPSHOT~c79dfc656d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.108 s) : 0, 1107545
Total [baseline] (10.758 s) : 0, 10758422
Agent [candidate] (1.109 s) : 0, 1109379
Total [candidate] (10.747 s) : 0, 10746596
section appsec
Agent [baseline] (1.288 s) : 0, 1287523
Total [baseline] (11.107 s) : 0, 11106675
Agent [candidate] (1.286 s) : 0, 1285861
Total [candidate] (11.203 s) : 0, 11202996
section iast
Agent [baseline] (1.243 s) : 0, 1242633
Total [baseline] (11.253 s) : 0, 11253363
Agent [candidate] (1.25 s) : 0, 1250168
Total [candidate] (11.287 s) : 0, 11286676
section profiling
Agent [baseline] (1.241 s) : 0, 1240929
Total [baseline] (11.16 s) : 0, 11160243
Agent [candidate] (1.229 s) : 0, 1229493
Total [candidate] (11.008 s) : 0, 11008117
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~c48da34534, baseline=1.57.0-SNAPSHOT~c79dfc656d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.509 ms) : 0, 1509
crashtracking [candidate] (1.49 ms) : 0, 1490
BytebuddyAgent [baseline] (713.153 ms) : 0, 713153
BytebuddyAgent [candidate] (713.136 ms) : 0, 713136
GlobalTracer [baseline] (249.331 ms) : 0, 249331
GlobalTracer [candidate] (250.614 ms) : 0, 250614
AppSec [baseline] (31.947 ms) : 0, 31947
AppSec [candidate] (32.221 ms) : 0, 32221
Debugger [baseline] (64.027 ms) : 0, 64027
Debugger [candidate] (64.206 ms) : 0, 64206
Remote Config [baseline] (633.954 µs) : 0, 634
Remote Config [candidate] (633.004 µs) : 0, 633
Telemetry [baseline] (8.314 ms) : 0, 8314
Telemetry [candidate] (8.372 ms) : 0, 8372
Flare Poller [baseline] (3.761 ms) : 0, 3761
Flare Poller [candidate] (3.786 ms) : 0, 3786
section appsec
crashtracking [baseline] (1.489 ms) : 0, 1489
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (735.675 ms) : 0, 735675
BytebuddyAgent [candidate] (733.388 ms) : 0, 733388
GlobalTracer [baseline] (242.195 ms) : 0, 242195
GlobalTracer [candidate] (241.44 ms) : 0, 241440
AppSec [baseline] (174.375 ms) : 0, 174375
AppSec [candidate] (174.645 ms) : 0, 174645
Debugger [baseline] (61.06 ms) : 0, 61060
Debugger [candidate] (62.114 ms) : 0, 62114
Remote Config [baseline] (673.266 µs) : 0, 673
Remote Config [candidate] (662.745 µs) : 0, 663
Telemetry [baseline] (8.328 ms) : 0, 8328
Telemetry [candidate] (8.344 ms) : 0, 8344
Flare Poller [baseline] (3.954 ms) : 0, 3954
Flare Poller [candidate] (4.042 ms) : 0, 4042
IAST [baseline] (24.818 ms) : 0, 24818
IAST [candidate] (24.784 ms) : 0, 24784
section iast
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.49 ms) : 0, 1490
BytebuddyAgent [baseline] (833.726 ms) : 0, 833726
BytebuddyAgent [candidate] (839.896 ms) : 0, 839896
GlobalTracer [baseline] (238.097 ms) : 0, 238097
GlobalTracer [candidate] (239.028 ms) : 0, 239028
AppSec [baseline] (34.19 ms) : 0, 34190
AppSec [candidate] (34.264 ms) : 0, 34264
Debugger [baseline] (61.127 ms) : 0, 61127
Debugger [candidate] (60.912 ms) : 0, 60912
Remote Config [baseline] (552.503 µs) : 0, 553
Remote Config [candidate] (540.2 µs) : 0, 540
Telemetry [baseline] (7.638 ms) : 0, 7638
Telemetry [candidate] (7.686 ms) : 0, 7686
Flare Poller [baseline] (3.54 ms) : 0, 3540
Flare Poller [candidate] (3.548 ms) : 0, 3548
IAST [baseline] (27.37 ms) : 0, 27370
IAST [candidate] (27.847 ms) : 0, 27847
section profiling
ProfilingAgent [baseline] (97.394 ms) : 0, 97394
ProfilingAgent [candidate] (96.411 ms) : 0, 96411
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (739.926 ms) : 0, 739926
BytebuddyAgent [candidate] (733.478 ms) : 0, 733478
GlobalTracer [baseline] (223.569 ms) : 0, 223569
GlobalTracer [candidate] (222.151 ms) : 0, 222151
AppSec [baseline] (32.495 ms) : 0, 32495
AppSec [candidate] (32.049 ms) : 0, 32049
Debugger [baseline] (64.114 ms) : 0, 64114
Debugger [candidate] (62.799 ms) : 0, 62799
Remote Config [baseline] (650.67 µs) : 0, 651
Remote Config [candidate] (642.587 µs) : 0, 643
Telemetry [baseline] (8.047 ms) : 0, 8047
Telemetry [candidate] (7.95 ms) : 0, 7950
Flare Poller [baseline] (3.838 ms) : 0, 3838
Flare Poller [candidate] (3.728 ms) : 0, 3728
Profiling [baseline] (97.99 ms) : 0, 97990
Profiling [candidate] (96.986 ms) : 0, 96986
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 18 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~c48da34534, baseline=1.57.0-SNAPSHOT~c79dfc656d
dateFormat X
axisFormat %s
section baseline
no_agent (18.425 ms) : 18232, 18618
. : milestone, 18425,
appsec (18.626 ms) : 18435, 18818
. : milestone, 18626,
code_origins (17.864 ms) : 17687, 18040
. : milestone, 17864,
iast (18.475 ms) : 18290, 18660
. : milestone, 18475,
profiling (18.84 ms) : 18647, 19033
. : milestone, 18840,
tracing (17.363 ms) : 17192, 17535
. : milestone, 17363,
section candidate
no_agent (19.587 ms) : 19387, 19787
. : milestone, 19587,
appsec (18.49 ms) : 18302, 18678
. : milestone, 18490,
code_origins (17.844 ms) : 17663, 18024
. : milestone, 17844,
iast (18.031 ms) : 17850, 18211
. : milestone, 18031,
profiling (18.586 ms) : 18403, 18770
. : milestone, 18586,
tracing (17.61 ms) : 17436, 17785
. : milestone, 17610,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~c48da34534, baseline=1.57.0-SNAPSHOT~c79dfc656d
dateFormat X
axisFormat %s
section baseline
no_agent (1.202 ms) : 1191, 1213
. : milestone, 1202,
iast (3.172 ms) : 3128, 3215
. : milestone, 3172,
iast_FULL (5.933 ms) : 5873, 5992
. : milestone, 5933,
iast_GLOBAL (3.674 ms) : 3615, 3733
. : milestone, 3674,
profiling (2.139 ms) : 2120, 2159
. : milestone, 2139,
tracing (1.807 ms) : 1792, 1822
. : milestone, 1807,
section candidate
no_agent (1.2 ms) : 1188, 1212
. : milestone, 1200,
iast (3.33 ms) : 3285, 3374
. : milestone, 3330,
iast_FULL (5.888 ms) : 5830, 5947
. : milestone, 5888,
iast_GLOBAL (3.677 ms) : 3614, 3739
. : milestone, 3677,
profiling (2.278 ms) : 2257, 2299
. : milestone, 2278,
tracing (1.804 ms) : 1789, 1818
. : milestone, 1804,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~c48da34534, baseline=1.57.0-SNAPSHOT~c79dfc656d
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.712 ms) : 3491, 3933
. : milestone, 3712,
iast (2.217 ms) : 2153, 2281
. : milestone, 2217,
iast_GLOBAL (2.263 ms) : 2198, 2328
. : milestone, 2263,
profiling (2.091 ms) : 2037, 2145
. : milestone, 2091,
tracing (2.054 ms) : 2003, 2105
. : milestone, 2054,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.588 ms) : 3379, 3798
. : milestone, 3588,
iast (2.213 ms) : 2148, 2277
. : milestone, 2213,
iast_GLOBAL (2.258 ms) : 2194, 2323
. : milestone, 2258,
profiling (2.097 ms) : 2043, 2151
. : milestone, 2097,
tracing (2.045 ms) : 1994, 2096
. : milestone, 2045,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~c48da34534, baseline=1.57.0-SNAPSHOT~c79dfc656d
dateFormat X
axisFormat %s
section baseline
no_agent (15.609 s) : 15609000, 15609000
. : milestone, 15609000,
appsec (14.723 s) : 14723000, 14723000
. : milestone, 14723000,
iast (18.5 s) : 18500000, 18500000
. : milestone, 18500000,
iast_GLOBAL (17.895 s) : 17895000, 17895000
. : milestone, 17895000,
profiling (14.616 s) : 14616000, 14616000
. : milestone, 14616000,
tracing (14.817 s) : 14817000, 14817000
. : milestone, 14817000,
section candidate
no_agent (14.983 s) : 14983000, 14983000
. : milestone, 14983000,
appsec (14.735 s) : 14735000, 14735000
. : milestone, 14735000,
iast (18.206 s) : 18206000, 18206000
. : milestone, 18206000,
iast_GLOBAL (17.944 s) : 17944000, 17944000
. : milestone, 17944000,
profiling (14.847 s) : 14847000, 14847000
. : milestone, 14847000,
tracing (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
|
d926f7a to
6d05d9a
Compare
6fea068 to
c73df5f
Compare
This comment has been minimized.
This comment has been minimized.
ddb9b65 to
cf1db21
Compare
8e8f321 to
6b99c46
Compare
effa6c3 to
0f57d15
Compare
6b99c46 to
6f66fc2
Compare
7550227 to
b65cb5e
Compare
359af31 to
61689a5
Compare
6fd2957 to
31a1f96
Compare
61689a5 to
52aa2a3
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 praise: Thanks for adding smoke tests
The app looks to crash at startup though 🤔
40b9326 to
fd73966
Compare
Thanks for the review. Yes, I forgot to remove the debugging configuration which I use locally to troubleshoot issues, should be fine by now 😄 |
fd73966 to
5727495
Compare
What Does This Do
Adds smoke tests for the OpenFeature Java provider (PR)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]